8000 Check if NGINX reload is complete by aphralG · Pull Request #1207 · nginx/agent · GitHub
[go: up one dir, main page]
Skip to content

Check if NGINX reload is complete #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 14, 2025
Merged

Check if NGINX reload is complete #1207

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7b51833
Check workers time created to check if nginx is reloaded
aphralG Jul 31, 2025
30b4da7
fix tests
aphralG Aug 11, 2025
7b86299
clean up
aphralG Aug 11, 2025
e54da95
Merge branch 'main' into add-nginx-reload-complete-check
aphralG Aug 12, 2025
b47aa6b
check test
aphralG Aug 12, 2025
bc1c0ed
fix tests
aphralG Aug 12, 2025
eb8d868
fix tests
aphralG Aug 12, 2025
1c4a96e
check workers parent id
aphralG Aug 12, 2025
a154f51
unit tests
aphralG Aug 13, 2025
c5c9ecb
8000 add more test cases
aphralG Aug 13, 2025
c4228bf
pr comments
aphralG Aug 13, 2025
fee476c
pr comments
aphralG Aug 13, 2025
df02594
test coverage
aphralG Aug 13, 2025
f2958cb
test coverage
aphralG Aug 13, 2025
3b20859
add configuration options for reload backoff
aphralG Aug 13, 2025
7cdaf0d
pr feedback
aphralG Aug 13, 2025
e66f452
fix unit tests
aphralG Aug 14, 2025
35a38ea
fix unit tests
aphralG Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test coverage
  • Loading branch information
@aphralG
aphralG committed Aug 13, 2025
commit f2958cb3133050cbfb5f6630ff7f978b04875a7c
17 changes: 8 additions & 9 deletions internal/resource/nginx_instance_process_operator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ import (
"context"
"errors"
"fmt"
"testing"
"time"

"github.com/nginx/agent/v3/internal/datasource/host/exec/execfakes"
"github.com/nginx/agent/v3/pkg/nginxprocess"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"testing"
"time"
)

func TestProcessOperator_FindParentProcessID(t *testing.T) {
Expand All @@ -31,12 +32,11 @@ func TestProcessOperator_FindParentProcessID(t *testing.T) {
configure arguments: ` + configArgs

tests := []struct {
expectedLog string
name string
instanceID string
expectErr error
name string // 16 bytes
instanceID string // 16 bytes
expectErr error // 16 bytes (interface)
nginxProcesses []*nginxprocess.Process // 24 bytes (slice header)
expectedPPID int32
nginxProcesses []*nginxprocess.Process
}{
{
name: "Test 1: Found parent process",
Expand Down Expand Up @@ -168,13 +168,12 @@ func TestProcessOperator_FindParentProcessID(t *testing.T) {
ppid, err := processOperator.FindParentProcessID(ctx, test.instanceID, test.nginxProcesses, mockExec)

if test.expectErr != nil {
assert.Error(tt, err)
require.Error(tt, err)
} else {
require.NoError(tt, err)
}

assert.Equal(tt, test.expectedPPID, ppid)

})
}
}
Loading
0