8000 Fix race conditions by aphralG · Pull Request #1094 · nginx/agent · GitHub
[go: up one dir, main page]
Skip to content

Fix race conditions #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 6, 2025
Merged

Fix race conditions #1094

merged 5 commits into from
Jun 6, 2025

Conversation

aphralG
Copy link
Contributor
@aphralG aphralG commented May 28, 2025

Proposed changes

Fix Race conditions caused by

  • OTel collector modifying back off settings
  • Instance Cache being updated
  • Process being converted

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this May 28, 2025
@aphralG aphralG requested a review from a team as a code owner May 28, 2025 11:02
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels May 28, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label May 28, 2025
sean-breen
sean-breen requested changes Jun 5, 2025
View reviewed changes
@aphralG aphralG requested review from sean-breen and dhurley June 5, 2025 15:04
@dhurley dhurley merged commit c89d9f1 into main Jun 6, 2025
37 of 38 checks passed
@dhurley dhurley deleted the fix-race-conditions branch June 6, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

+1 more reviewer

@john-david3 john-david3 john-david3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aphralG aphralG

Labels
bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aphralG @dhurley @craigell @sean-breen @john-david3 @oCHRISo
0