Open
Conversation
brad-hansen
reviewed
Jun 16, 2022
src/DbUp.sln
Outdated
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "dbup-redshift", "dbup-redshift\dbup-redshift.csproj", "{7E77DD23-2E16-471A-897B-C67FB73C62C8}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SQLiteSampleApplication", "Samples\SQLiteSampleApplication\SQLiteSampleApplication.csproj", "{FD894CD2-4D67-4BD8-8E3C-CDA4BD7A00A3}" |
There was a problem hiding this comment.
Will this change cause any upstream issues?
Collaborator
Author
There was a problem hiding this comment.
ooh good catch
| /// <summary> | ||
| /// Creates new Cassandra Connection Manager | ||
| /// </summary> | ||
| public CassandraConnectionManager(string connectionString) : base(l => new CqlConnection(connectionString)) |
There was a problem hiding this comment.
Could this be a discard instead of 'l'?
| return | ||
| $@"create table {FqSchemaTableName} ( | ||
| id UUID PRIMARY KEY, | ||
| script_name text, |
There was a problem hiding this comment.
Does this need to be a partition key?
Collaborator
Author
There was a problem hiding this comment.
My thinking was id being the sole partition key. Due to value being generated the partitions should rotate around. Given each script name will be unique again partitions would rotate around. What is the benefit of the composite partition key?
Let's chat.
b695921 to
d251d35
Compare
Pull in DataStax C# driver to interact with Cassandra 3. Add support for script execution and journal. Using "schema" variable to represent a keyspace. Does not create keyspace - if keyspace is provided then assumes it is present. DBUp can be used to execute a script to setup keyspace if running with a NullJournal.
d251d35 to
f3a0f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.