fix(ui): simplify signaling server error toast for non-admins#17322
Open
fix(ui): simplify signaling server error toast for non-admins#17322
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
| ) | ||
| } else { | ||
| showError( | ||
| t('spreed', 'The server is misconfigured. Please contact your administration.'), |
Member
There was a problem hiding this comment.
I kind of dislike the generic string. Is anything logged for admins when this happens?
Contributor
There was a problem hiding this comment.
Admins should see it in the system check?
Contributor
Author
There was a problem hiding this comment.
This message is for general users. Admins see the full message.
Member
There was a problem hiding this comment.
But the admin might not even log in or use the call UI themselves, so maybe they don't see it.
Antreesy
reviewed
Mar 9, 2026
| ) | ||
| if (getCurrentUser()?.isAdmin) { | ||
| showError( | ||
| t('spreed', 'The configured signaling server needs to be updated to be compatible with this version of Talk'), |
Contributor
There was a problem hiding this comment.
Since we're changing the string, i would even rewrite it to High-performance backend needs to be updated...
| ) | ||
| } else { | ||
| showError( | ||
| t('spreed', 'The server is misconfigured. Please contact your administration.'), |
Contributor
There was a problem hiding this comment.
Admins should see it in the system check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist