fix(meetings): reword meetigns related messages on Home page and in title#17320
Open
fix(meetings): reword meetigns related messages on Home page and in title#17320
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
reviewed
Mar 9, 2026
|
|
||
| // So we can unset names & descriptions in case the user deleted them | ||
| $this->roomService->setName($room, $name ?? $this->l10n->t('Talk conversation for event')); | ||
| $this->roomService->setName($room, $name ?? $this->l10n->t('Meeting conversation')); |
Contributor
There was a problem hiding this comment.
We are using 'Meeting' string as a fallback in frontend already, could be reusing that
Suggested change
| $this->roomService->setName($room, $name ?? $this->l10n->t('Meeting conversation')); | |
| $this->roomService->setName($room, $name ?? $this->l10n->t('Meeting')); |
| :title="t('spreed', 'Schedule meetings')" | ||
| :subtitle="t('spreed', 'You don\'t have any upcoming meetings')" | ||
| :description="t('spreed', 'Schedule a meeting from your calendar. A Talk conversation needs to be set as location to show up here')"> | ||
| :description="t('spreed', 'Calendar events with a conversation link as the location are shown here')"> |
Contributor
There was a problem hiding this comment.
Maybe worth mentioning, that it also covers 'Meetings scheduled from the conversation'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Talk conversation for event->Meeting conversation🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist