10000 fix: eslint setup and migrate to eslint 9+flatconfig by ndom91 · Pull Request #11749 · nextauthjs/next-auth · GitHub
[go: up one dir, main page]
Skip to content

fix: eslint setup and migrate to eslint 9+flatconfig #11749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 2, 2024
Merged

fix: eslint setup and migrate to eslint 9+flatconfig #11749

merged 10 commits into from
Sep 2, 2024

Conversation

ndom91
Copy link
Member
@ndom91 ndom91 commented Sep 1, 2024 •
edited
Loading

☕️ Reasoning

  • Eslint setup was broken
  • Fix setup and while we're at it, migrate to Eslint 9 and flatconfig
  • Since we haven't had this running for a while, we seem to have a good amount of legitimate issues open. I'll follow up with a separate PR fixing those

Note: The eslint oom seems to be a common issue when including 10+ projects. Found a fix here which includes creating that separate tsconfig.eslint.json 🙏

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@vercel Vercel
Copy link
vercel bot commented Sep 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 3:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 3:16pm
proxy ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 3:16pm

@github-actions github-actions bot removed the next-auth label Sep 1, 2024
@ndom91 ndom91 force-pushed the ndom91/eslint-9-flatconfig branch from 9f38dac to 7b0ca4b Compare September 1, 2024 15:08
@ndom91 ndom91 changed the title feat: new flatconfig eslint.config.js fix: eslint setup and migrate to eslint9+flatconfig Sep 1, 2024
@ndom91 ndom91 changed the title fix: eslint setup and migrate to eslint9+flatconfig fix: eslint setup and migrate to eslint 9+flatconfig Sep 1, 2024
@ndom91 ndom91 mentioned this pull request Sep 1, 2024
Merged
3 tasks
@ndom91 ndom91 marked this pull request as ready for review September 1, 2024 15:42
@ndom91
Copy link
Member Author
ndom91 commented Sep 1, 2024

After this is merged, we can merge this follow-up PR containing fixes to a bunch of eslint issues that are newly resurfaced

ThangHuuVu
ThangHuuVu approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member
@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you use any codemod or tools t 8000 o migrate all the configs?

@ndom91
Copy link
Member Author
ndom91 commented Sep 2, 2024

LGTM, did you use any codemod or tools to migrate all the configs?

Yeah kind of, they have a little CLI migration tool (see: https://eslint.org/docs/latest/use/configure/migration-guide), but it just throws most of your things in a this like eslint.compat() function call. It's usually a good starting point at least though, so you can pull the stuff that got put in there out one-by-one by checking their docs to see if they work in flatconfig and how to use it, etc.

@ndom91 ndom91 merged commit 4b4642a into main Sep 2, 2024
12 of 13 checks passed
@ndom91 ndom91 deleted the ndom91/eslint-9-flatconfig branch September 2, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44 balazsorban44 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OOM when many (>10) project configs passed to the parser
2 participants
@ndom91 @ThangHuuVu
0