FIX remove regressor multi_label tag #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam2392
approved these changes
Dec 17, 2024
treeple/tree/_classes.py
Outdated
| @@ -2441,7 +2441,7 @@ def __sklearn_tags__(self): | |||
| # XXX: nans should be supportable in SPORF by just using RF-like splits on missing values | |||
| # However, for MORF it is not supported | |||
| tags = super().__sklearn_tags__() | |||
| tags.regressor_tags.multi_label = True | |||
| # tags.regressor_tags.multi_label = True | |||
There was a problem hiding this comment.
Perhaps let's just add an inline comment saying "TODO: add regression support"?
adam2392
requested changes
Dec 17, 2024
adam2392
reviewed
Dec 23, 2024
| @@ -29,7 +29,7 @@ jobs: | |||
| matrix: | |||
| os: # see scipy wheels.yml GH actions | |||
| - [ubuntu-22.04, manylinux, x86_64] | |||
| - [macos-12, macosx, x86_64] | |||
| - [macos-latest, macosx, x86_64] | |||
There was a problem hiding this comment.
For my education, why do we need this change?
There was a problem hiding this comment.
Sorry for late reply. It's due to the drop of support for the previous Mac version.
|
Merged for new changes on honest prune/kernel method #345 |
PSSF23
added a commit
to neurodata/scikit-learn
that referenced
this pull request
Mar 5, 2025
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CONTRIBUTING.md --> #### Reference Issues/PRs neurodata/treeple#339 <!-- Example: Fixes scikit-learn#1234. See also scikit-learn#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: https://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?