8000 [Show PR] Submodule for 3rd party vendors by adam2392 · Pull Request #42 · neurodata/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[Show PR] Submodule for 3rd party vendors #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,23 @@ jobs:
root: doc/_build/html
paths: .

deploy:
docker:
- image: cimg/python:3.8.12
steps:
- checkout
- run: ./build_tools/circle/checkout_merge_commit.sh
# Attach documentation generated in the 'doc' step so that it can be
# deployed.
- attach_workspace:
at: doc/_build/html
- run: ls -ltrh doc/_build/html/stable
- deploy:
command: |
if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$ ]]; then
bash build_tools/circle/push_doc.sh doc/_build/html/stable
fi
# XXX: in order to make sure our fork passes all the CIs and not remove too many LOC, we don't want to deploy
# deploy:
# docker:
# - image: cimg/python:3.8.12
# steps:
# - checkout
# - run: ./build_tools/circle/checkout_merge_commit.sh
# # Attach documentation generated in the 'doc' step so that it can be
# # deployed.
# - attach_workspace:
# at: doc/_build/html
# - run: ls -ltrh doc/_build/html/stable
# - deploy:
# command: |
# if [[ "${CIRCLE_BRANCH}" =~ ^main$|^[0-9]+\.[0-9]+\.X$ ]]; then
# bash build_tools/circle/push_doc.sh doc/_build/html/stable
# fi

workflows:
version: 2
Expand Down
4 changes: 2 additions & 2 deletions .cirrus.star
8000
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
load("cirrus", "env", "fs", "http")

def main(ctx):
# Only run for scikit-learn/scikit-learn. For debugging on a fork, you can
# Only run for neurodata/scikit-learn. For debugging on a fork, you can
# comment out the following condition.
if env.get("CIRRUS_REPO_FULL_NAME") != "scikit-learn/scikit-learn":
if env.get("CIRRUS_REPO_FULL_NAME") != "neurodata/scikit-learn":
return []

arm_wheel_yaml = "build_tools/cirrus/arm_wheel.yml"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/check-changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ jobs:
check:
name: A reviewer will let you know if it is required or can be bypassed
runs-on: ubuntu-latest
if: ${{ contains(github.event.pull_request.labels.*.name, 'No Changelog Needed') == 0 }}
if: ${{ contains(github.event.pull_request.labels.*.name, 'No Changelog Needed') == 0 && github.repository == 'scikit-learn/scikit-learn' }}
steps:
- name: Get PR number and milestone
run: |
echo "PR_NUMBER=${{ github.event.pull_request.number }}" >> $GITHUB_ENV
echo "TAGGED_MILESTONE=${{ github.event.pull_request.milestone.title }}" >> $GITHUB_ENV
echo "${{ github.repository }}"
- uses: actions/checkout@v3
with:
fetch-depth: '0'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
check-manifest:
# Don't run on forks
if: github.repository == 'scikit-learn/scikit-learn'
if: github.repository == 'neurodata/scikit-learn'

runs-on: ubuntu-latest
steps:
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/check-upstream.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Create Github Actions workflow that checks upstream scikit-learn 'main' branch and
# creates or updates
# an existing pull request to https://github.com/neurodata/scikit-learn:fork.
# Runs the check weekly.
# Creates a pull request if there are changes.

# name: Check upstream scikit-learn

# on:
# schedule:
# - cron: '0 0 * * 0'

# jobs:
# check-upstream:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - name: Check upstream scikit-learn
# uses: neurodata/check-upstream@main
# with:
# upstream: scikit-learn/scikit-learn
# fork: neurodata/scikit-learn
# branch: fork
# token: ${{ secrets.GITHUB_TOKEN }}

# # Creates a pull request if there are changes.

4 changes: 2 additions & 2 deletions .github/workflows/labeler-module.yml
< F438 /tr>
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: thomasjpfan/labeler@v2.5.1
continue-on-error: true
if: github.repository == 'scikit-learn/scikit-learn'
if: github.repository == 'neurodata/scikit-learn'
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
max-labels: "3"
Expand All @@ -27,7 +27,7 @@ jobs:
steps:
- uses: thomasjpfan/labeler@v2.5.1
continue-on-error: true
if: github.repository == 'scikit-learn/scikit-learn'
if: github.repository == 'neurodata/scikit-learn'
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
configuration-path: ".github/labeler-file-extensions.yml"
2 changes: 1 addition & 1 deletion .github/workflows/update_tracking_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
jobs:
update_tracking_issue:
runs-on: ubuntu-latest
if: github.repository == 'scikit-learn/scikit-learn' && github.event_name == 'schedule'
if: github.repository == 'neurodata/scikit-learn' && github.event_name == 'schedule'
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
Expand Down
33 changes: 5 additions & 28 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ on:
- cron: "42 3 */1 * *"
push:
branches:
- main
- fork
# Release branches
- "[0-9]+.[0-9]+.X"
pull_request:
branches:
- main
- fork
- "[0-9]+.[0-9]+.X"
# Manual run
workflow_dispatch:
Expand All @@ -26,7 +26,7 @@ jobs:
check_build_trigger:
name: Check build trigger
runs-on: ubuntu-latest
if: github.repository == 'scikit-learn/scikit-learn'
if: github.repository == 'neurodata/scikit-learn'
outputs:
build: ${{ steps.check_build_trigger.outputs.build }}

Expand Down Expand Up @@ -178,31 +178,8 @@ jobs:
with:
path: dist/*.tar.gz

# Upload the wheels and the source distribution
upload_anaconda:
name: Upload to Anaconda
runs-on: ubuntu-latest
needs: [build_wheels, build_sdist]
# The artifacts cannot be uploaded on PRs
if: github.event_name != 'pull_request'

steps:
- name: Checkout scikit-learn
uses: actions/checkout@v3

- name: Download artifacts
uses: actions/download-artifact@v3
- uses: actions/upload-artifact@v3
with:
path: dist
name: ${{ matrix.python[0] }}-${{ matrix.os[1] }}

- name: Setup Python
uses: actions/setup-python@v4

- name: Upload artifacts
env:
# Secret variables need to be mapped to environment variables explicitly
SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN: ${{ secrets.SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN }}
SCIKIT_LEARN_STAGING_UPLOAD_TOKEN: ${{ secrets.SCIKIT_LEARN_STAGING_UPLOAD_TOKEN }}
ARTIFACTS_PATH: dist/artifact
# Force a replacement if the remote file already exists
run: bash build_tools/github/upload_anaconda.sh
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
build
sklearn/datasets/__config__.py
sklearn/**/*.html
scikit_learn_tree.egg-info/*

dist/
MANIFEST
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,6 @@ doc-noplot: inplace
code-analysis:
flake8 sklearn | grep -v __init__ | grep -v external
pylint -E -i y sklearn/ -d E1103,E0611,E1101

build-dev:
pip install --verbose --no-build-isolation --editable .
Loading
0