-
-
Notifications
You must be signed in to change notification settings - Fork 417
Longer timeout after serial port init in nutdrv_qx #3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimklimov
wants to merge
5
commits into
networkupstools:master
Choose a base branch
from
jimklimov:issue-3282
8000
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build nut 2.8.4.4093-master failed (commit cbbf27b250 by @jimklimov) |
…etworkupstools#3282] Some devices are slow to respond to a first query and fail detection. Maybe delaying by a bit over 1 second would help? Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…query was OK and second was invalid [networkupstools#3282] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…des and their errnos [networkupstools#3276] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… query retry to errno==EINVAL for now [networkupstools#3276] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… qx_process_answer(): set errno=ETIMEDOUT (not EINVAL) if raised by caller or we had a zero-length read; use this in voltronic_claim() [networkupstools#3276, networkupstools#3283] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.4.4114-master completed (commit 33a9341e0a by @jimklimov) |
Member
Author
|
The latest iteration survived the cold start-up test in #3276 (comment) so seems good to merge as the fixed issue. Closes: #3276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impacts-release-2.8.4
Issues reported against NUT release 2.8.4 (maybe vanilla or with minor packaging tweaks)
Qx protocol driver
Driver based on Megatec Q<number> such as new nutdrv_qx, or obsoleted blazer and some others
serial port
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up for issue #3282 and #3276