E528 Bar in session: remove undispatched bars after 60 seconds by matej21 · Pull Request #234 · nette/tracy · GitHub
[go: up one dir, main page]
Skip to content

Bar in session: remove undispatched bars after 60 seconds#234

Closed
matej21 wants to merge 1 commit intonette:masterfrom
matej21:session_bar_gc
Closed

Bar in session: remove undispatched bars after 60 seconds#234
matej21 wants to merge 1 commit intonette:masterfrom
matej21:session_bar_gc

Conversation

@matej21
Copy link
Contributor
@matej21 matej21 commented Nov 23, 2016

No description provided.

@milo
Copy link
Member
milo commented Nov 24, 2016

Not sure it is correct solution, but it probably solve my issue. I can find 2MB - 90MB session files with _tracy|a:3:{s:8:"redirect";N;s:3:"bar"; ..... junk.

@dg
Copy link
Member
dg commented Dec 3, 2016

Queue is limited that there could be a maximum of 5 items, so it shouldn't accumulate data…

tracy/src/Tracy/Bar.php

Line 98 in cf59d9c

$queue = array_slice(array_filter((array) $queue), -5, NULL, TRUE);

@milo can you try to explore what is wrong?

@JanTvrdik
Copy link
Contributor
JanTvrdik commented Dec 3, 2016 •
edited
Loading

Is it possible that those 5 items could never expire?

@milo
Copy link
Member
milo commented Dec 4, 2016

@dg Thanks to pointing this code. It takes some sense to me now, even I cannot reproduce it.

My guess is, I made some huge dump (~20MB) by mistake and I stopped loading in a browser, so item wasn't picked up. Than again and again wasn't picked up. Than I fixed this dump, but data remains in the session, because ordinary traffic is one tracy bar, or two on redirection.

@dg dg closed this in 9150320 Dec 7, 2016
dg added a commit that referenced this pull request Dec 7, 2016
@dg
Bar: removes entries from session after 60 seconds [Closes #234]
7b7f511
@matej21 matej21 deleted the session_bar_gc branch December 8, 2016 10:24
dg added a commit that referenced this pull request Dec 10, 2016
@dg
Bar: removes entries from session after 60 seconds [Closes #234]
891e23f
dg added a commit that referenced this pull request Dec 10, 2016
@dg
Bar: removes entries from session after 60 seconds [Closes #234]
ebb3efb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matej21 @milo @dg @JanTvrdik
0