8000 Strip tags from window title when opening in new window by adrianbj · Pull Request #203 · nette/tracy · GitHub
[go: up one dir, main page]
Skip to content

Strip tags from window title when opening in new window#203

Merged
dg merged 2 commits intonette:masterfrom
adrianbj:master
Jun 28, 2016
Merged

Strip tags from window title when opening in new window#203
dg merged 2 commits intonette:masterfrom
adrianbj:master

Conversation

@adrianbj
Copy link
Contributor
@adrianbj adrianbj commented Jun 22, 2016

No description provided.

@JanTvrdik
Copy link
Contributor
JanTvrdik commented Jun 23, 2016

Why not just use textContent instead of innerHtml?

@adrianbj
Copy link
Contributor Author
adrianbj commented Jun 23, 2016

Why not just use textContent instead of innerHtml?

It might be totally fine. I have just read several things on the browser inconsistencies with textContent so thought that a regex replace would be safer.

http://perfectionkills.com/the-poor-misunderstood-innerText/
http://clubajax.org/plain-text-vs-innertext-vs-textcontent/

In particular the line break discrepancies. It probably won't be an issue in this use case, but you can never be certain what a panel author may put inside the h1 tags.

@dg
Copy link
Member
dg commented Jun 26, 2016 •
edited
Loading

Problem with regexp is that it is not safe, ie. <span title=">"> will not be stripped correctly.

Whitespace inside <title> is compessed, so textcontent should be fine.

@dg dg merged commit 841aff7 into nette:master Jun 28, 2016
@dg
Copy link
Member
dg commented Jun 28, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianbj @JanTvrdik @dg
0