Closed
Conversation
Member
Contributor
Author
|
So is it ready to be merged? |
Member
|
Not yet. IMHO one thing should be done differently but I have to try it. |
milo
requested changes
Sep 10, 2018
| } | ||
|
|
||
| $light = $total ? $total < 5 : count(file($entry)) < 50; | ||
| $nameReplacePairs = []; |
Member
There was a problem hiding this comment.
There should be single replacement, common path of all sources. Otherway duplicates may appear.
And it can be done before foreach loop.
Contributor
Author
There was a problem hiding this comment.
@milo What is the easiest way to find common path of all sources?
| $iterator = is_dir($this->source) | ||
| ? new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($this->source)) | ||
| : new \ArrayIterator([new \SplFileInfo($this->source)]); | ||
| $iterator = new \AppendIterator(); |
Member
There was a problem hiding this comment.
No brackets according to CS consistency.
| } | ||
| } | ||
| $source = dirname($source . 'x'); | ||
| $sources[] = $source; |
| ? new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($source)) | ||
| : new \ArrayIterator([new \SplFileInfo($source)]); | ||
| $iterator->append($partialIterator); | ||
| } |
Member
There was a problem hiding this comment.
Since $partialIterator is not used anywhere else, write it this way:
$iterator->append(
is_dir($source)
? new \Recursive.....,
: new \Array.....
);
Member
|
Sorry if you see any mess here. I'm trying the review and resolve/unresolve conversation functionality. |
9de88a3 to
f89cab0
Compare
Contributor
Author
|
@milo Thanks for your review. I have edited it. |
milo
pushed a commit
that referenced
this pull request
Sep 11, 2018
milo
approved these changes
Sep 11, 2018
Member
|
Merged 2286131. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for repeatable
--coverage-srcoption. It is useful when you have got eg. multiple directories in root of your project which you want to generate coverage for.