8000 SessionStorage: Fix clearing identity in case of clearAuthentication(true). by janbarasek · Pull Request #55 · nette/security · GitHub
[go: up one dir, main page]

Skip to content

SessionStorage: Fix clearing identity in case of clearAuthentication(true).#55

Merged
dg merged 1 commit intonette:masterfrom
janbarasek:patch-9
Jan 5, 2021
Merged

SessionStorage: Fix clearing identity in case of clearAuthentication(true).#55
dg merged 1 commit intonette:masterfrom
janbarasek:patch-9

Conversation

@janbarasek
Copy link
Contributor
@janbarasek janbarasek commented Jan 5, 2021
  • bug fix
  • BC break? yes

User defined code (for logout function):

$this->userStorage->clearAuthentication(true);
$this->userStorage->setExpiration(null, true);

Mark user as unauthenticated, but an original identity kept stored in Session. I think when clearAuthentication(true) the identity must be removed.

@dg
8E4C Copy link
Member
dg commented Jan 5, 2021

Thanks

@dg dg merged commit 520b68f into nette:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0