8000 improve parse code in Extractor by yoosefap · Pull Request #150 · nette/php-generator · GitHub
[go: up one dir, main page]

Skip to content

improve parse code in Extractor#150

Merged
dg merged 1 commit intonette:masterfrom
yoosefap:master
Jan 17, 2024
Merged

improve parse code in Extractor#150
dg merged 1 commit intonette:masterfrom
yoosefap:master

Conversation

@yoosefap
Copy link
Contributor
  • bug fix / new feature?
  • BC break? yes/no
  • doc PR: nette/docs#???

@dg
Copy link
Member
dg commented Jan 15, 2024

It should be compatible with version 4 too

@JanTvrdik
Copy link
Contributor
JanTvrdik commented Jan 16, 2024

ParserFactory::createForNewestSupportedVersion was backported to PHP-Parser 4.18, so sth like ^4.18 || ^5.0 should work

@dg dg merged commit 821a89c into nette:master Jan 17, 2024
@dg
Copy link
Member
dg commented Jan 17, 2024

Thanks

dg pushed a commit that referenced this pull request Jan 17, 2024
dg pushed a commit that referenced this pull request Jan 17, 2024
dg pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0