Ensure that object class contains path from root namespace#117
Merged
dg merged 1 commit intonette:masterfrom Sep 21, 2022
Merged
Ensure that object class contains path from root namespace#117dg merged 1 commit intonette:masterfrom
dg merged 1 commit intonette:masterfrom
Conversation
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 3, 2022
dg
pushed a commit
that referenced
this pull request
Oct 4, 2022
dg
pushed a commit
that referenced
this pull request
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
at first thank you for the package.
I've found that created objects in default parameters in methods does not contain valid class path (it should be from a root, currently uses namespace of the file which is incorrect).
This PR ensures that the object class always uses root path namespace.
Here is current "broken" expectation in my test:
I'm using
$assertMethod = (new Factory())->fromMethodReflection($method);Also I've noticed a deprecated usage of (string) reflectionType (it is deprecated since 7.1). I've currently implemented possible alternative solution (should cover everything I've found):
If you are interested I can contribute it to the factory (so a I can later us it?).
Have a great day,