8000 Tests and fixes for #970 by Elijen · Pull Request #971 · nette/nette · GitHub
[go: up one dir, main page]
Skip to content

Tests and fixes for #970#971

Closed
Elijen wants to merge 5 commits intonette:masterfrom
Elijen:master
Closed

Tests and fixes for #970#971
Elijen wants to merge 5 commits intonette:masterfrom
Elijen:master

Conversation

@Elijen
Copy link
Contributor
@Elijen Elijen commented Feb 18, 2013

No description provided.

@Elijen Elijen mentioned this pull request Feb 18, 2013
Nette\Database - Error: key() expects parameter 1 to be array, null given #970
Closed
@hrach
Copy link
Contributor
hrach commented Feb 18, 2013

Well. thanks! The bugfix is correct (only missing space after )).
But tests are wrong. Pleas add them after this tests: https://github.com/nette/nette/blob/master/tests/Nette/Database/Table.cache.rows.phpt#L55 since it's not problem of toArray but accessColumn, which is about caching :)

@Elijen
Copy link
Contributor Author
Elijen commented Feb 18, 2013

Ok, done. Sorry, first time commiting to nette :)

@hrach
Copy link
Contributor
hrach commented Feb 18, 2013
  1. make pull request only from branchces, not from master
  2. try squashing (merge 2nd & 3rd commit, merge 1st and 4th commit, remove 5th commit)

:)

@dg dg closed this in c0f1320 Feb 18, 2013
@dimkalinux
Copy link
Contributor
dimkalinux commented Oct 5, 2013

Why this patch not backported to 2.0.12 version?

@dg
Copy link
Member
dg commented Nov 5, 2013

Will be in 2.0.13

dg pushed a commit that referenced this pull request Nov 5, 2013
@Elijen @dg
fixed ActiveRow::toArray [Closes #970] [Closes #971]
bad7a88
dg pushed a commit to nette/database that referenced this pull request Mar 18, 2014
@Elijen @dg
fixed ActiveRow::toArray [Closes nette/nette#970] [Closes nette/nette…
fb26f06 
…#971]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Elijen @hrach @dimkalinux @dg
0