8000 Configurable name of cookie browserKey by jasin755 · Pull Request #64 · nette/http · GitHub
[go: up one dir, main page]
Skip to content

Configurable name of cookie browserKey#64

Closed
jasin755 wants to merge 1 commit intonette:masterfrom
jasin755:patch-1
Closed

Configurable name of cookie browserKey#64
jasin755 wants to merge 1 commit intonette:masterfrom
jasin755:patch-1

Conversation

@jasin755
Copy link
@jasin755 jasin755 commented Jun 16, 2015

No description provided.

@JanTvrdik
Copy link
Contributor
JanTvrdik commented Jun 16, 2015

It breaks tests. You cannot use $options like that.

@jasin755
Copy link
Author
jasin755 commented Jun 17, 2015

What is the correct way?

@Unlink
Copy link
Unlink commented Jun 18, 2015

I think, you should add new field for that and sets it in SessionExtension.
$options are used for php session variables

@dg
Copy link
Member
dg commented Jun 18, 2015

I think that configurable name is needless complexity, better is to use constant.

@jasin755
Copy link
Author
jasin755 commented Jun 18, 2015

Occasionally are found clients who for some reason refuses to show what framework is used. There is no way (except hack) how to accommodate them.

@dg dg force-pushed the master branch 7 times, most recently from 1dc599c to f35d20f Compare November 5, 2015 00:41
@dg dg force-pushed the master branch 2 times, most recently from 7981e33 to 3fb64f5 Compare July 21, 2016 12:07
@dg
Copy link
Member
dg commented Sep 27, 2016

Closed by #103

@dg dg closed this Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasin755 @JanTvrdik @Unlink @dg
0