8000 Cannot set session cookie parameters for already started session by mabar · Pull Request #134 · nette/http · GitHub
[go: up one dir, main page]
Skip to content

Cannot set session cookie parameters for already started session#134

Closed
mabar wants to merge 2 commits intonette:masterfrom
mabar:master
Closed

Cannot set session cookie parameters for already started session#134
mabar wants to merge 2 commits intonette:masterfrom
mabar:master

Conversation

@mabar
Copy link
Contributor
@mabar mabar commented Mar 6, 2018
  • bug fix? yes
  • new feature? no
  • BC break? probably not

Fixes Warning session_set_cookie_params(): Cannot change session cookie parameters when session is active
It happens when Session::setOptions() is called multiple times.
Can be tested with php 7.2+ only. In previous versions it failed silently (see https://bugs.php.net/bug.php?id=75650&thanks=2)

@dg dg force-pushed the master branch 2 times, most recently from 898e948 to b550f69 Compare March 8, 2018 12:29
dg added a commit that referenced this pull request Mar 14, 2018
@dg
Session: don't call session_set_cookie_params() when values was not c…
9bc983a 
…hanged [Closes #134]
@dg dg closed this in b395717 Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
@dg
Session: don't call session_set_cookie_params() when values was not c…
3d794c3 
…hanged [Closes #134][Closes #23]
dg added a commit that referenced this pull request Mar 14, 2018
@dg
Session: don't call session_set_cookie_params() when values was not c…
d8390f2 
…hanged [Closes #134][Closes #23]
dg added a commit that referenced this pull request Mar 14, 2018
@dg
Session: don't call session_set_cookie_params() when values was not c…
446bb7b 
…hanged [Closes #134][Closes #23]
dg added a commit that referenced this pull request Mar 14, 2018
@dg
Session: don't call session_set_cookie_params() when values was not c…
3ea16d9 
…hanged [Closes #134][Closes #23]
@mabar
Copy link
Contributor Author
mabar commented Apr 13, 2018

@dg Thanks but nothing changed :(
It makes no sense to call session_name($name) or session_set_cookie_params() twice during one request even if parameters was changed.

@dg
Copy link
Member
dg commented Apr 14, 2018

Why not?

@mabar
Copy link
Contributor Author
mabar commented Apr 14, 2018

My previous statement is not exact.

  • It makes no sense to call session_name or session_set_cookie_params() after session_start()
    It throws warning everytime in php 7.2 (and fails silently in previous versions).
<?php
error_reporting(E_ALL);
session_start();
session_name('foo');
session_set_cookie_params(0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabar @dg
0