Fixes nv-file-select reset bug when queued #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h $compile'd self
|
Tnx. This works for me ... Now I am able to use input multiple to add, remove and re-add new files ... more than once. Hope will be took into consideration for a master merge |
This was referenced May 15, 2016
|
@nervgh, sorry for late action. |
nervgh
added a commit
that referenced
this pull request
Jun 13, 2016
Merge branch 'master' of https://github.com/denkan/angular-file-upload into denkan-master # Conflicts: # dist/angular-file-upload.js # dist/angular-file-upload.js.map # dist/angular-file-upload.min.js # dist/angular-file-upload.min.js.map # src/services/FileSelect.js
|
@denkan , thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
el.replaceWith( el.clone(this) )drops the change-event (even though it should deep clone?). This cause the file picker to stop working after adding the first file(s).Fixed by replace its element with re-$compile'd self.