Angular dependency injection broken in minified files #631

josencv · 2016-05-11T18:08:34Z

The issue is very straighforward. The angular dependencies are broken in the minified version of the library (v2.2.3).

I investigated a little and it looks like this is not a problem of the uglifier webpack plugin.

The problems lies in convertion from ES6 to ES5, that is, babel iseltf. From version 6.0 and above the code:

export default (args) => {
 ...
}

transforms into:

exports.default = function (args) {
  ...
}

instead of:

module.exports = function (args) {
  ...
}

The angular modules injection are explicit, but they are using common js module syntax:

module.exports.$inject = ['args'];

So the dependencies are being injected to a wrong target, causing the whole problem.

The solution involves a change in the design of the whole module, so I think @nervgh should decide how to solve this.

This article explains in depth the problem and the posible solutions.

nervgh · 2016-05-11T21:37:23Z

@josencv thanks! Fixed in v2.3.1 😄

josencv · 2016-05-11T21:57:40Z

Thanks for the quick fix. Now works without problems.

nervgh · 2016-05-12T08:08:22Z

You are welcome! Thank you for the informative issue!

nervgh added a commit that referenced this issue May 11, 2016

Fixed: "Angular dependency injection broken in minified files (#631)"

c191050

nervgh closed this as completed May 11, 2016

Provide feedback