Simon/passive robust ecdsa #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
e5790a6 to
8d1fc35
Compare
8d1fc35 to
c6b1ed1
Compare
Check that me is in participant list of presign and sign
c6b1ed1 to
a4cb954
Compare
a4cb954 to
3bcc578
Compare
3bcc578 to
f58abe6
Compare
There was a problem hiding this comment.
Pull Request Overview
This massive PR implements the Robust ECDSA scheme with passive security and restructures the codebase with major architectural changes. The changes include implementing a new robust ECDSA algorithm, unifying type systems, isolating crypto functions, and generalizing testing infrastructure.
- Implementation of Robust ECDSA scheme with passive security alongside existing OT-based ECDSA
- Removal of the CSCurve trait in favor of unified Frost library types (Secp256K1Sha256)
- Reorganization of crypto functions into dedicated modules with cleaner separation
Reviewed Changes
Copilot reviewed 54 out of 67 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/serde.rs | Complete removal of custom serialization utilities |
| src/protocol/mod.rs | Updated imports and added new error types for robust ECDSA |
| src/protocol/internal.rs | Inlined encoding functions and updated deserialization calls |
| src/participants.rs | Unified lagrange coefficient calculation and improved method signatures |
| src/lib.rs | Stripped library documentation and removed legacy module exports |
| src/generic_dkg.rs | Major refactoring to use Frost types and new polynomial/commitment system |
| src/ecdsa/robust_ecdsa/* | New implementation of passive robust ECDSA scheme |
| src/ecdsa/ot_based_ecdsa/* | Refactored OT-based ECDSA to use unified types |
Comments suppressed due to low confidence (1)
src/generic_dkg.rs:362
- [nitpick] Variable name 'all_full_commitments' is inconsistent with the previous 'all_commitments'. Consider using a more descriptive name that clearly indicates this contains commitments with proper threshold size.
let mut all_full_commitments = ParticipantMap::new(&participants);
Return type should be &[Participant] instead of &Vec to provide a more flexible API that doesn't expose the underlying container type.
0102933 to
f788f81
Compare
netrome
requested changes
Jul 23, 2025
…s adversaries from sending serialized empty polynomials
README.md
Outdated
| This repository offers a cryptographic implementation of **threshold ECDSA** and **threshold EdDSA**. The implementation has undergone professional <ins>audit</ins> and supports arbitrary numbers | ||
| of signing parties and thresholds. | ||
|
|
||
| The former implementation is imported from the [Cait-Sith](https://github.com/cronokirby/cait-sith) library and amended to meet our industrial needs. This includes modifying parts of the code to improve the performance, augment the security, and generalize functions' syntax. |
There was a problem hiding this comment.
This is a nit and a follow-up, but it would be nice to have a more specific tldr of the changes.
There was a problem hiding this comment.
Agree! how about we push this to when closing #5?
netrome
reviewed
Jul 25, 2025
added 2 commits
July 28, 2025 14:32
…f and derefmut traits to prevent exposing the coefficients and popping elements from the polynomial
kuksag
reviewed
Jul 28, 2025
added 4 commits
July 29, 2025 18:02
…nally to the polynomials
This was referenced Aug 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This massive PR includes:
The review might go smoother if it is isolated into reviewing one algorithm at a time (EdDSA folder, OT-based ECDSA (old cait-sith), and the robust-ecdsa)