8000 Add border curve for continuous borders on iOS by lewiscasewell · Pull Request #904 · nativewind/nativewind · GitHub
[go: up one dir, main page]
Skip to content

Add border curve for continuous borders on iOS #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add border curve for continuous borders on iOS #904

wants to merge 2 commits into from

Conversation

lewiscasewell
Copy link
@lewiscasewell lewiscasewell commented May 3, 2024 •
edited
Loading

Adding border curve support to iOS

Related issue #522

Adds border-continuous and border-circular for RN styles borderCurve: "continuous" and borderCurve: "circular" respectively.

Demo

Continuous:
Simulator Screenshot - iPhone 15 - 2024-05-03 at 13 20 49
Circular:
Simulator Screenshot - iPhone 15 - 2024-05-03 at 13 20 55

@vercel Vercel
Copy link
vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nativewind ✅ Ready (Inspect) Visit Preview May 3, 2024 0:56am

@lewiscasewell lewiscasewell changed the title add border curve to ios Add border curve for continuous borders on iOS May 3, 2024
lewiscasewell
lewiscasewell commented May 3, 2024
View reviewed changes
examples/expo-router/nativewind-env.d.ts Outdated
@@ -0,0 +1 @@
/// <reference types="nativewind/types" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to remove type errors for className as per the docs: https://www.nativewind.dev/v4/getting-started/typescript

@quentez
Copy link
quentez commented Aug 2, 2024 •
edited
Loading

Hello @lewiscasewell, is this something I can add to my own app before it gets merged here? I tried re-using the plugin and theme extension, but that doesn't do anything 🤔

@lewiscasewell
Copy link
Author
lewiscasewell commented Aug 2, 2024 •
edited
Loading

Hello @lewiscasewell, is this something I can add to my own app before it gets merged here? I tried re-using the plugin and theme extension, but that doesn't do anything 🤔

Yeah @quentez, you can copy these changes and use patch-package

@danstepanov danstepanov added the help wanted Extra attention is needed label Mar 1, 2025
@quentez
Copy link
quentez commented Jun 4, 2025

Are there any blockers on this? Happy to help get it through the finish line.

@lewiscasewell
Copy link
Author

Had some merge conflicts which i have fixed @danstepanov @marklawlor ready for review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewiscasewell @quentez @danstepanov
0