10BC0 Fix tailwind cli path error by feledori · Pull Request #840 · nativewind/nativewind · GitHub
[go: up one dir, main page]
Skip to content

Fix tailwind cli path error #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tailwind cli path error #840

wants to merge 1 commit into from

Conversation

feledori
Copy link
@feledori feledori commented Mar 6, 2024

This should fix the cli error by passing the cli path as a string.

I had the same issue as #813 and executed the tw cli directly. I noticed that the blank spaces were not escaped in the cli path which the error gave me. The referenced issue also shows an error with a path which has a blank space.

Only tested this on mac so unix works, but can't test windows.

This should close #813.

@vercel Vercel
Copy link
vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nativewind ✅ Ready (Inspect) Visit Preview Mar 6, 2024 7:50pm

@theblondealex
Copy link
theblondealex commented Mar 7, 2024 •
edited
Loading

I have just tested this and I am on windows and can clarify it worked too! thank you so much, can't believe I didn't notice it myself

Would be worth getting this merged @marklawlor as its a breaking issue for people with blank spaces in file paths

@feledori
Copy link
Author
feledori commented Mar 7, 2024

Glad I could help!

@benrbowers
Copy link

@feledori This doesn't seem to work for me, though it is worth noting that my path does not seem to have any spaces. Just thought worth pointing out that this is only a partial solution to #836, t3:#910

@feledori
Copy link
Author
feledori commented Mar 14, 2024 •
edited
Loading

@benrbowers This has nothing to do with the issue you tagged. It fixes #813. I will rename the pull request to make it clear.

@feledori feledori changed the title Fix tailwind cli error Fix tailwind cli path error Mar 14, 2024
@benrbowers benrbowers mentioned this pull request Mar 15, 2024
Closed
@feledori feledori mentioned this pull request Mar 25, 2024
Closed
@2-fly-4-ai
Copy link

This is a major issue that needs to be rectified. Which version of this package implements this change.

This issue with not wrapping the command in a string on windows, has broken the turborepo-t3 starter template.

@ELASHMAWYDEV
Copy link

Please add this fix ASAP, I kept trying to fix the error for 3 days!
I removed the black space from my project directory and it worked!

@theblondealex
Copy link

Please add this fix ASAP, I kept trying to fix the error for 3 days!

I removed the black space from my project directory and it worked!

I'm pretty sure this is fixed in the latest nativewind v4

@danstepanov danstepanov added the help wanted Extra attention is needed label Mar 1, 2025
@danstepanov danstepanov mentioned this pull request Mar 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running TailwindCSS CLI, please run the CLI manually to see the error
6 participants
@feledori @theblondealex @benrbowers @2-fly-4-ai @ELASHMAWYDEV @danstepanov
0