-
-
Notifications
You must be signed in to change notification settings - Fork 245
8000
Show file tree
Hide file tree
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 5, 2019
Mar 5, 2019
Mar 5, 2019
Mar 6, 2019
Mar 18, 2019
Mar 18, 2019
Mar 20, 2019
Mar 20, 2019
8000
Mar 20, 2019
Mar 20, 2019
Loading
support for Vue 2.6 #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
support for Vue 2.6 #445
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d7790ae
updated packages
farfromrefug 75da6d3
fix for latest rollup
farfromrefug 18d377d
refactoring to NOT import tns-core-modules when required from webpack
farfromrefug 7e8768e
removed deprecated test. Faster as now regex testing
farfromrefug d3bd9b3
fixed view directive for latest vue
farfromrefug 8e0e8d7
removed custom console log as it crashes the app when complex objects…
farfromrefug 267603f
update for process.env to be correctly set / created.
farfromrefug 46c69b6
fixed scopedFn returning array in 2.6
farfromrefug a9032f6
actually better test
farfromrefug 3ee431c
needs to be done on oldVnode too
farfromrefug 26f876c
should be a let!
farfromrefug 85aea58
bring back strict mode
farfromrefug 2b26db5
bring warning back
farfromrefug 91b4285
use latest vue
farfromrefug 8972f31
fix directive reading of arg
farfromrefug 270afe8
test for global.process
farfromrefug 293cb5c
create constants
farfromrefug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export { parseComponent } from './compiler/sfc/parser' | ||
| export { compile, compileToFunctions } from './compiler/index' | ||
| export { registerElement } from './element-registry' | ||
| // register all components | ||
| export { registerElement } from './compiler/element-registry' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| import { registerElement } from '../element-register' | ||
| export { registerElement } | ||
|
|
||
| registerElement( | ||
| 'AbsoluteLayout', | ||
| () => require('tns-core-modules/ui/layouts/absolute-layout').AbsoluteLayout | ||
| ) | ||
| registerElement( | ||
| 'ActivityIndicator', | ||
| () => require('tns-core-modules/ui/activity-indicator').ActivityIndicator | ||
| ) | ||
| registerElement('Border', () => require('tns-core-modules/ui/border').Border) | ||
| registerElement('Button', () => require('tns-core-modules/ui/button').Button) | ||
| registerElement( | ||
| 'ContentView', | ||
| () => require('tns-core-modules/ui/content-view').ContentView | ||
| ) | ||
| registerElement( | ||
| 'DatePicker', | ||
| () => require('tns-core-modules/ui/date-picker').DatePicker, | ||
| { | ||
| model: { | ||
| prop: 'date', | ||
| event: 'dateChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'DockLayout', | ||
| () => require('tns-core-modules/ui/layouts/dock-layout').DockLayout | ||
| ) | ||
| registerElement( | ||
| 'GridLayout', | ||
| () => require('tns-core-modules/ui/layouts/grid-layout').GridLayout | ||
| ) | ||
| registerElement( | ||
| 'HtmlView', | ||
| () => require('tns-core-modules/ui/html-view').HtmlView | ||
| ) | ||
| registerElement('Image', () => require('tns-core-modules/ui/image').Image) | ||
| registerElement('img', () => require('tns-core-modules/ui/image').Image) | ||
| registerElement('Label', () => require('tns-core-modules/ui/label').Label) | ||
| registerElement( | ||
| 'ListPicker', | ||
| () => require('tns-core-modules/ui/list-picker').ListPicker, | ||
| { | ||
| model: { | ||
| prop: 'selectedIndex', | ||
| event: 'selectedIndexChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'NativeActionBar', | ||
| () => require('tns-core-modules/ui/action-bar').ActionBar | ||
| ) | ||
| registerElement( | ||
| 'NativeActionItem', | ||
| () => require('tns-core-modules/ui/action-bar').ActionItem | ||
| ) | ||
| registerElement( | ||
| 'NativeListView', | ||
| () => require('tns-core-modules/ui/list-view').ListView | ||
| ) | ||
| registerElement( | ||
| 'NativeNavigationButton', | ||
| () => require('tns-core-modules/ui/action-bar').NavigationButton | ||
| ) | ||
| registerElement('Page', () => require('tns-core-modules/ui/page').Page, { | ||
| skipAddToDom: true | ||
| }) | ||
| registerElement( | ||
| 'Placeholder', | ||
| () => require('tns-core-modules/ui/placeholder').Placeholder | ||
| ) | ||
| registerElement( | ||
| 'Progress', | ||
| () => require('tns-core-modules/ui/progress').Progress | ||
| ) | ||
| registerElement( | ||
| 'ProxyViewContainer', | ||
| () => require('tns-core-modules/ui/proxy-view-container').ProxyViewContainer | ||
| ) | ||
| registerElement( | ||
| 'Repeater', | ||
| () => require('tns-core-modules/ui/repeater').Repeater | ||
| ) | ||
| registerElement( | ||
| 'ScrollView', | ||
| () => require('tns-core-modules/ui/scroll-view').ScrollView | ||
| ) | ||
| registerElement( | ||
| 'SearchBar', | ||
| () => require('tns-core-modules/ui/search-bar').SearchBar, | ||
| { | ||
| model: { | ||
| prop: 'text', | ||
| event: 'textChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'SegmentedBar', | ||
| () => require('tns-core-modules/ui/segmented-bar').SegmentedBar, | ||
| { | ||
| model: { | ||
| prop: 'selectedIndex', | ||
| event: 'selectedIndexChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'SegmentedBarItem', | ||
| () => require('tns-core-modules/ui/segmented-bar').SegmentedBarItem | ||
| ) | ||
| registerElement('Slider', () => require('tns-core-modules/ui/slider').Slider, { | ||
| model: { | ||
| prop: 'value', | ||
| event: 'valueChange' | ||
| } | ||
| }) | ||
| registerElement( | ||
| 'StackLayout', | ||
| () => require('tns-core-modules/ui/layouts/stack-layout').StackLayout | ||
| ) | ||
| registerElement( | ||
| 'FlexboxLayout', | ||
| () => require('tns-core-modules/ui/layouts/flexbox-layout').FlexboxLayout | ||
| ) | ||
| registerElement('Switch', () => require('tns-core-modules/ui/switch').Switch, { | ||
| model: { | ||
| prop: 'checked', | ||
| event: 'checkedChange' | ||
| } | ||
| }) | ||
|
|
||
| registerElement( | ||
| 'NativeTabView', | ||
| () => require('tns-core-modules/ui/tab-view').TabView, | ||
| { | ||
| model: { | ||
| prop: 'selectedIndex', | ||
| event: 'selectedIndexChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'NativeTabViewItem', | ||
| () => require('tns-core-modules/ui/tab-view').TabViewItem, | ||
| { | ||
| skipAddToDom: true | ||
| } | ||
| ) | ||
|
|
||
| registerElement( | ||
| 'TextField', | ||
| () => require('tns-core-modules/ui/text-field').TextField | ||
| ) | ||
| registerElement( | ||
| 'TextView', | ||
| () => require('tns-core-modules/ui/text-view').TextView | ||
| ) | ||
| registerElement( | ||
| 'TimePicker', | ||
| () => require('tns-core-modules/ui/time-picker').TimePicker, | ||
| { | ||
| model: { | ||
| prop: 'time', | ||
| event: 'timeChange' | ||
| } | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'WebView', | ||
| () => require('tns-core-modules/ui/web-view').WebView | ||
| ) | ||
| registerElement( | ||
| 'WrapLayout', | ||
| () => require('tns-core-modules/ui/layouts/wrap-layout').WrapLayout | ||
| ) | ||
| registerElement( | ||
| 'FormattedString', | ||
| () => require('text/formatted-string').FormattedString | ||
| ) | ||
| registerElement('Span', () => require('text/span').Span) | ||
|
|
||
| registerElement( | ||
| 'DetachedContainer', | ||
| () => require('tns-core-modules/ui/proxy-view-container').ProxyViewContainer, | ||
| { | ||
| skipAddToDom: true | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'DetachedText', | ||
| () => require('tns-core-modules/ui/placeholder').Placeholder, | ||
| { | ||
| skipAddToDom: true | ||
| } | ||
| ) | ||
| registerElement( | ||
| 'Comment', | ||
| () => require('tns-core-modules/ui/placeholder').Placeholder | ||
| ) | ||
| registerElement( | ||
| 'Document', | ||
| () => require('tns-core-modules/ui/proxy-view-container').ProxyViewContainer, | ||
| { | ||
| skipAddToDom: true | ||
| } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const VUE_VM_REF = '__vue_vm_ref__' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farfromrefug Does this remove all the development related help messages that vue prints? If so - can this be re-enabled while developing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it s the user choice by replacing within his weback config. that code was making the appear always, even in prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farfromrefug alright, so as far as I understand this change, this should still allow the help messages to appear unless webpack sets the env to "production"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rigor789 indeed it will appear by default because it checks for
NODE_ENV !== 'production'which is the case asNODE_ENVis not defined.However that change allow the user tu define
NODE_ENVtoproductionwhen building for production, and thus remove all the warning.It is just moved to userland