10BC0 Avoid `std.meta.Tuple` by robbielyman · Pull Request #176 · natecraddock/ziglua · GitHub
[go: up one dir, main page]
Skip to content

Avoid std.meta.Tuple #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Avoid std.meta.Tuple #176

wants to merge 10 commits into from

Conversation

robbielyman
Copy link
Collaborator

Recent Zig changes around anonymous struct types also seem potentially relevant as reasons to avoid over-instantiating tuple types?

@robbielyman
8000 feat: add pushNumeric, toNumeric and checkNumeric
74e7cf7 
These functions rely (lightly) on Zig's comptime to minimize some of the
annoying overhead of writing `@intCast` and `@floatCast` all the time by
making those builtins part of the function definition. However, since
those builtins assert in builds with runtime safety enabled, these
functions will crash the program if called with bad Lua input. More
discussion is warranted about the tradeoffs of going this route before
merging.

Resolves #172.
@robbielyman
fix: remove pushNumeric
0ffdfc0
@robbielyman
fix: checkNumeric raises a lua error
3ea22a6
@robbielyman
fix: toNumeric raises a Zig error
ffa2205
@robbielyman
fix: remove pushNumeric from test, typo in toNumeric
8407657
@robbielyman
fix: error.IntegerCastFailed -> error.Overflow
436ceb7
@robbielyman
fix: add test for checkNumeric
47d4e38
@robbielyman
fix: error message inconsistency outside of test control
16806d3
@robbielyman
fix: toStringEx not available in 5.1
9d2f73e
@robbielyman
fix: avoid std.meta.Tuple
3af1661 
Redoing the argument parsing in `TypeOfWrap` and `wrap` seems bad.
Also doing the compiler's job (providing compile errors) by hand seems
bad. This PR reverses courses on both of these choices.
@robbielyman robbielyman closed this Sep 3, 2025
@robbielyman robbielyman deleted the push-rssnvtoykzuo branch September 3, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robbielyman
0