Implement SslMode=preferred #158

caleblloyd · 2017-01-11T18:13:24Z

Fixes Support SSL without Client Certificates and add SslMode=preferred #157
Adds SslMode=preferred as default functionality for SslMode (this now matches Oracle's connector)
Allows for SSL connection without client certs
Adds test cases for:
- SslMode=preferred
- Good client cert (signed by same CA as server's ssl-ca)
- Bad client cert (signed by different CA than server's ssl-ca)

bgrainger · 2017-01-11T19:03:37Z

src/MySqlConnector/MySqlClient/MySqlSslMode.cs

-		/// Do not use SSL. This is the default.
+		/// Use SSL if the server supports it. This is the default.
+		/// </summary>
+		Preferred,


We should keep the same order as https://github.com/mysql/mysql-connector-net/blob/5864e6b21a8b32f5154b53d1610278abb3cb1cee/Source/MySql.Data/MysqlDefs.cs#L363 so that default(MySqlSslMode) is the same (source compatibility). (Even though that's not the same default that the connector would actually use.)

bgrainger · 2017-01-11T19:03:54Z

src/MySqlConnector/Serialization/MySqlSession.cs

@@ -87,8 +87,13 @@ public MySqlSession(ConnectionPool pool, int poolGeneration)
 			if (cs.UseCompression && (initialHandshake.ProtocolCapabilities & ProtocolCapabilities.Compress) == 0)
 				cs = cs.WithUseCompression(false);

-			if (cs.SslMode != MySqlSslMode.None)
+			var serverSupporsSsl = (initialHandshake.ProtocolCapabilities & ProtocolCapabilities.Ssl) != 0;


Typo: Supports

caleblloyd · 2017-01-11T19:31:15Z

We should keep the same order as https://github.com/mysql/mysql-connector-net/blob/5864e6b21a8b32f5154b53d1610278abb3cb1cee/Source/MySql.Data/MysqlDefs.cs#L363

I changed the order to match. I left out the Prefered=Preferred alias. I guess this would help with misspelling, but it also makes MySqlSslMode.Prefered the first auto-suggested ENUM in my IDE, which is going to promote misspelling.

I don't think that Aliases count as an integer value for enumerations, so the integer values should still match up without it.

caleblloyd · 2017-01-11T19:34:15Z

I ran SideBySide.Baseline tests with SSL. MySql.Data has an issue reading client certs from our default path (maybe the . in .ci is causing an issue for them?), but once I move them out to a different path the Baseline tests pass.

bgrainger · 2017-01-12T18:59:59Z

Shipped in 0.11.0.

caleblloyd force-pushed the f_ssl_preferred branch 2 times, most recently from 2702824 to 98725bb Compare January 11, 2017 18:23

bgrainger reviewed Jan 11, 2017

View reviewed changes

caleblloyd force-pushed the f_ssl_preferred branch 2 times, most recently from 8c96885 to 3caec34 Compare January 11, 2017 19:12

SslMode=preferred. Fixes mysql-net#157

6dda8a5

caleblloyd force-pushed the f_ssl_preferred branch from 3caec34 to 6dda8a5 Compare January 11, 2017 19:27

bgrainger merged commit 2830865 into mysql-net:master Jan 12, 2017

caleblloyd deleted the f_ssl_preferred branch February 7, 2017 02:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement SslMode=preferred #158

Implement SslMode=preferred #158

Implement SslMode=preferred #158

Implement SslMode=preferred #158

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment