8000 schema: for consistency, allow `<clef>` within `<scoreDef>` by lpugin · Pull Request #1475 · music-encoding/music-encoding · GitHub
[go: up one dir, main page]
Skip to content

schema: for consistency, allow <clef> within <scoreDef> #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

schema: for consistency, allow <clef> within <scoreDef> #1475

wants to merge 1 commit into from

Conversation

lpugin
Copy link
Member
@lpugin lpugin commented May 23, 2024

For consistency, allow <clef> within <scoreDef> since @clef.* are allowed

@lpugin lpugin added this to the MEI 5.x milestone May 23, 2024
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label May 23, 2024
@musicEnfanthen musicEnfanthen changed the title For consistency, allow <clef> within <scoreDef> schema: for consistency, allow <clef> within <scoreDef> May 26, 2024
@lpugin lpugin requested review from bwbohl and musicEnfanthen May 27, 2024 14:36
@bwbohl bwbohl added Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Status: Needs Work Component: Images changes to source/images/* (assigned automatically) and removed Component: Core Schema changes to source/modules/* (assigned automatically) labels Nov 13, 2024
bwbohl
bwbohl approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member
@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is more consistent now.

@rettinghaus
Copy link
Member

I'm still not convinced that this is an improvement, but if the decision is to move in this direction, it is at least more consistent, yes.

@bwbohl bwbohl modified the milestones: MEI 5.x, MEI 6 Nov 15, 2024
@bwbohl
Copy link
Member
bwbohl commented Nov 15, 2024

@musicEnfanthen and I revisited this PR today and looked at the context. We think we should tackle and discuss this in a broader context with more people, e.g., a developer workshop. Thus, postponing to MEI 6.

@bwbohl bwbohl self-requested a review November 15, 2024 10:29
@bwbohl bwbohl marked this pull request as draft November 15, 2024 10:30
@lpugin
Copy link
Member Author
lpugin commented Nov 15, 2024

OK. It did not look like a big deal to me, though.

@musicEnfanthen musicEnfanthen mentioned this pull request Jan 31, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musicEnfanthen musicEnfanthen Awaiting requested review from musicEnfanthen

@bwbohl bwbohl Awaiting requested review from bwbohl

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Images changes to source/images/* (assigned automatically) Status: Needs Review
Projects
ODD meetings
Status: 👀 Ready for review
Milestone
MEI 6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lpugin @rettinghaus @bwbohl
0