Support building arm64 and universal2 wheels on x86_64 #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a7e463.
|
Interesting. So the idea is to build both wheels then fuse them? It might be nice to document this somewhere. |
|
Here's a test run. https://github.com/isuruf/gmpy2-wheels/runs/1705061075?check_suite_focus=true (note that building both |
mattip
reviewed
Jan 15, 2021
|
ping |
|
@mattip @radarhere - any chance of another quick review here? - as this is a moderately big change. |
radarhere
reviewed
Jan 20, 2021
radarhere
reviewed
Jan 20, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jan 20, 2021
radarhere
reviewed
Jan 20, 2021
radarhere
reviewed
Jan 20, 2021
Changed functions to setup instead of wrap
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
|
I propose to merge this when tests all passed. Any objections? |
radarhere
reviewed
Jan 21, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jan 21, 2021
|
OK - let's give this one a shot. |
|
Thanks for your persistence @isuruf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.