8000 Send empty dictionary instead of null for iot queries (#1145) · msz-coder/python-kasa@81e2685 · GitHub
[go: up one dir, main page]
Skip to content

Commit 81e2685

Browse files
sdb9696sdb9696
authored
Send empty dictionary instead of null for iot queries (python-kasa#1145)
1 parent db80c38 commit 81e2685

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

‎devtools/dump_devinfo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ async def get_legacy_fixture(device):
285285
try:
286286
click.echo(f"Testing {test_call}..", nl=False)
287287
info = await device.protocol.query(
288-
{test_call.module: {test_call.method: None}}
288+
{test_call.module: {test_call.method: {}}}
289289
)
290290
resp = info[test_call.module]
291291
except Exception as ex:
@@ -302,7 +302,7 @@ async def get_legacy_fixture(device):
302302
final_query = defaultdict(defaultdict)
303303
final = defaultdict(defaultdict)
304304
for succ, resp in successes:
305-
final_query[succ.module][succ.method] = None
305+
final_query[succ.module][succ.method] = {}
306306
final[succ.module][succ.method] = resp
307307

308308
final = default_to_regular(final)

‎kasa/device_factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232

3333
_LOGGER = logging.getLogger(__name__)
3434

35-
GET_SYSINFO_QUERY = {
36-
"system": {"get_sysinfo": None},
35+
GET_SYSINFO_QUERY: dict[str, dict[str, dict]] = {
36+
"system": {"get_sysinfo": {}},
3737
}
3838

3939

‎kasa/discover.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,8 @@ class Discover:
296296

297297
DISCOVERY_PORT = 9999
298298

299-
DISCOVERY_QUERY = {
300-
"system": {"get_sysinfo": None},
299+
DISCOVERY_QUERY: dict[str, dict[str, dict]] = {
300+
"system": {"get_sysinfo": {}},
301301
}
302302

303303
DISCOVERY_PORT_2 = 20002

‎kasa/iot/iotdevice.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ def add_module(self, name: str | ModuleName[Module], module: IotModule):
207207
def _create_request(
208208
self, target: str, cmd: str, arg: dict | None = None, child_ids=None
209209
):
210+
if arg is None:
211+
arg = {}
210212
request: dict[str, Any] = {target: {cmd: arg}}
211213
if child_ids is not None:
212214
request = {"context": {"child_ids": child_ids}, target: {cmd: arg}}

‎kasa/klaptransport.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ class KlapTransport(BaseTransport):
8888
"""
8989

9090
DEFAULT_PORT: int = 80
91-
DISCOVERY_QUERY = {"system": {"get_sysinfo": None}}
9291
SESSION_COOKIE_NAME = "TP_SESSIONID"
9392
TIMEOUT_COOKIE_NAME = "TIMEOUT"
9493

0 commit comments

Comments
 (0)
0