parse_pcap_klap: require source host (python-kasa#1137)

rytilahti · web-flow · commit db80c383a908 · 2024-09-30T09:15:16.000+01:00
Adds a mandatory `--source-host` to make sure the correct handshake
is captured when multiple hosts are communicating with the target device.
diff --git a/devtools/parse_pcap_klap.py b/devtools/parse_pcap_klap.py
@@ -212,6 +212,7 @@ def main(
     username,
     password,
     device_ip,
+    source_host,
     pcap_file_path,
     output_json_name=None,
 ):
@@ -232,7 +233,6 @@ def main(
     )
 
     operator = Operator(KlapTransportV2(config=fake_device), creds)
-
     packets = []
 
     # pyshark is a little weird in how it handles iteration,
@@ -241,6 +241,8 @@ def main(
         try:
             packet = capture.next()
             packet_number = capture._current_packet
+            if packet.ip.src != source_host:
+                continue
             # we only care about http packets
             if hasattr(
                 packet, "http"
@@ -325,6 +327,11 @@ def main(
     required=True,
     help="the IP of the smart device as it appears in the pcap file.",
 )
+@click.option(
+    "--source-host",
+    required=True,
+    help="the IP of the device communicating with the smart device.",
+)
 @click.option(
     "--username",
     required=True,
@@ -348,14 +355,14 @@ def main(
     required=False,
     help="The name of the output file, relative to the current directory.",
 )
-async def cli(username, password, host, pcap_file_path, output):
+async def cli(username, password, host, source_host, pcap_file_path, output):
     """Export KLAP data in JSON format from a PCAP file."""
     # pyshark does not work within a running event loop and we don't want to
     # install click as well as asyncclick so run in a new thread.
     loop = asyncio.new_event_loop()
     thread = Thread(
         target=main,
-        args=[loop, username, password, host, pcap_file_path, output],
+        args=[loop, username, password, host, source_host, pcap_file_path, output],
         daemon=True,
     )
     thread.start()
