Unpacker: add tell() #227
Merged
Unpacker: add tell() #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfolz
commented
Apr 29, 2017
| @@ -314,6 +315,7 @@ cdef class Unpacker(object): | |||
| cdef object object_hook, object_pairs_hook, list_hook, ext_hook | |||
| cdef object encoding, unicode_errors | |||
| cdef Py_ssize_t max_buffer_size | |||
| cdef uint64_t stream_offset | |||
There was a problem hiding this comment.
Py_ssize_t may be 32bit, which is a bit small even today. 16 Exabyte should be plenty for some time.
There was a problem hiding this comment.
Should be good for 30+ years (if you can unpack continuously at 16GB/s ;))
|
Thanks! This way is indeed a lot simpler internally and externally than what I tried in my patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a demand for tracking offset (e.g., for indexing) while unpacking from stream. Before 1.0, it is suggested to use
write_bytesfor that purpose. Since it was really easy and a lot more efficient, this PR adds atell()method toUnpacker.