8000 fix typos and other cosmetic issues by ThomasWaldmann · Pull Request #214 · msgpack/msgpack-python · GitHub
[go: up one dir, main page]

Skip to content

fix typos and other cosmetic issues #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2017
Merged

fix typos and other cosmetic issues #214

merged 1 commit into from
Jan 11, 2017

Conversation

ThomasWaldmann
Copy link
Contributor

cosmetic issues:

  • reST headlines' underline length needs to match the headline length
    (looks like somebody is / was using a proportional font)
  • Cython code lines do not need to be terminated with a semicolon
  • always use triple-double-quotes for docstrings

I did the PR against release-0.4 branch, hope this is correct to get it fixed in next release and also get it merged from there into master.

cosmetic issues:
- reST headlines' underline length needs to match the headline length
  (looks like somebody is / was using a proportional font)
- Cython code lines do not need to be terminated with a semicolon
- always use triple-double-quotes for docstrings
@methane methane merged commit e3fea94 into msgpack:release-0.4 Jan 11, 2017
@methane
Copy link
Member
methane commented Jan 11, 2017

thanks

@ThomasWaldmann ThomasWaldmann deleted the fix-typos branch January 11, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0