Define the initialize_copy and respond_to_missing? methods as private
#6708
Conversation
…vate It is preferable for them to be private even when defined via `mrb_define_method()`. This mimics CRuby's behavior. ref: https://github.com/ruby/ruby/blob/v4.0.0/vm_method.c#L1329-L1336
Summary of ChangesHello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aligns the method visibility behavior of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly changes the default visibility of initialize_copy and respond_to_missing? to private, aligning mruby's behavior with CRuby. The change is implemented in mrb_define_method_raw by adding these two methods to the check that already exists for initialize. This is a good improvement for compatibility. The implementation is correct and I have no further suggestions.
It is preferable for them to be private even when defined via
mrb_define_method().This mimics CRuby's behavior.
ref: https://github.com/ruby/ruby/blob/v4.0.0/vm_method.c#L1329-L1336