8000 Refactor task class to use symbol IDs by Asmod4n · Pull Request #6706 · mruby/mruby · GitHub
[go: up one dir, main page]
Skip to content

Refactor task class to use symbol IDs #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matz merged 1 commit into from
Jan 20, 2026
Merged

Refactor task class to use symbol IDs #6706

8000 matz merged 1 commit into from
Jan 20, 2026
+3 −3

Conversation

@Asmod4n
Copy link
Contributor
@Asmod4n Asmod4n commented Jan 17, 2026 •
edited
Loading

Would like to use tasks in the future, but need compile time symbol IDs for that.

@Asmod4n Asmod4n requested a review from matz as a code owner January 17, 2026 18:31
@gemini-code-assist
Copy link
gemini-code-assist bot commented Jan 17, 2026

Summary of Changes

Hello @Asmod4n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the mruby-task gem's core C implementation to leverage symbol IDs more directly for class and keyword argument handling. By transitioning from string literals and their associated runtime interning to pre-computed or directly referenced symbol IDs, the changes aim to improve performance and reduce overhead in key areas of the task management system.

Highlights

  • Keyword Argument Handling: Replaced runtime string interning for keyword argument names (e.g., 'name', 'priority') with compile-time symbol ID generation using MRB_SYM.
  • Class Retrieval: Updated the method for retrieving the 'Task' class from mrb_class_get (string-based lookup) to mrb_class_get_id (symbol ID-based lookup) using MRB_SYM.
  • Class Definition: Modified the definition of the 'Task' class from mrb_define_class to mrb_define_class_id, utilizing MRB_SYM for direct symbol ID registration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 17, 2026
View reviewed changes
Copy link
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors parts of the task implementation to use symbol IDs instead of string literals for class and keyword argument lookups. This is a good practice in mruby for improving performance. The changes are correct and well-implemented. I have one suggestion to further improve the code by using mrb_class_ptr(self) which will make task creation more robust, especially with regards to subclassing.

@matz matz merged commit c25b562 into mruby:master Jan 20, 2026
18 checks passed
@Asmod4n Asmod4n deleted the patch-4 branch January 20, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matz matz Awaiting requested review from matz matz is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mrbgems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Asmod4n @matz
0