8000 Fix 2 Matplotlib errors by carlinmack · Pull Request #60 · mpld3/mplexporter · GitHub
[go: up one dir, main page]
Skip to content

Fix 2 Matplotlib errors #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix 2 Matplotlib errors #60

wants to merge 2 commits into from

Conversation

carlinmack
Copy link

Matplotlib recently removed the _gridOnMajor attributes, source: matplotlib/matplotlib#18769

Additionally collection.get_offset_position() has been deprecated and the default behaviour is now only screen, source: https://matplotlib.org/api/collections_api.html#matplotlib.collections.Collection

@carlinmack
Fix major axis grid on condition
739793f 
fix mpld3/mpld3#479, see plotly/plotly.py#2913
@carlinmack
Fix error: matplotlib deprecation of get_offset_position
5279e5e 
```mpld3/mplexporter/exporter.py:267: MatplotlibDeprecationWarning:
The get_offset_position function was deprecated in Matplotlib 3.3 and will be removed two minor releases later.
  offset_order = offset_dict[collection.get_offset_position()]```

The new default is "screen" which corresponds to "after". Source: https://matplotlib.org/api/collections_api.html#matplotlib.collections.Collection
@carlinmack
Copy link
Author

the failed check doesn't appear to be a problem with my PR

@cliffckerr
Copy link
Member

Thanks for finding this @carlinmack ! We're looking into it. Do you know off the top of your head what version of Matplotlib this patch is back-compatible with? (Wondering if we need an if statement to catch both, or if the new version is OK.) And agree with you that CI is failing for unrelated reasons. cc @vladh

@jklymak jklymak mentioned this pull request Nov 26, 2020
Open
@vladh
Copy link
Member
vladh commented Nov 27, 2020

Fixed in release 0.5.2 in mpld3/mpld3@4617a12 !

@vladh vladh closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlinmack @cliffckerr @vladh
0