Follow up PCF-561 Add copy run values to extended row #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 93.47% 93.56% +0.08%
==========================================
Files 94 94
Lines 2637 2641 +4
Branches 524 526 +2
==========================================
+ Hits 2465 2471 +6
+ Misses 153 152 -1
+ Partials 19 18 -1 ☔ View full report in Codecov by Sentry. |
b639c1b to
c77ddcf
Compare
c77ddcf to
5672aa1
Compare
julienw
approved these changes
Feb 21, 2025
| expect(showLessButton).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should copy run values when "Copy values" is clicked', async () => { |
| }; | ||
|
|
||
| const onCopyValues = () => { | ||
| void navigator.clipboard.writeText(values.toString()); |
There was a problem hiding this comment.
I'm not fully sure of what we should copy. I was initially thinking separated by spaces (like how it is displayed) would have been better, but trying it with google spreadsheet convinced me that commas are a better option. So it's good to me!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #844
It adds the
Copy resultsbutton inside the extended row.deploy test link