Add QtCompat.isValid() #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wrapper around: * shiboken.isValid() * shiboken2.isValid() * sip.isdeleted()
houndci-bot
reviewed
Mar 30, 2019
|
|
||
| if Qt.IsPyQt4 or Qt.IsPyQt5: | ||
| isdeleted = getattr(Qt, "_sip").isdeleted | ||
| def func(obj): |
There was a problem hiding this comment.
expected 1 blank line before a nested definition, found 0
|
|
|
Looks great to me, thank you! For consistency, I'd prefer if you could sign the CLA to protect users and future contributors from legal trouble. |
OEP
commented
Apr 1, 2019
|
Sorry for the delay on this one, completely slipped my mind. Thanks @OEP |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I brought this up originally in #53 where wrapInstance() and friends were being discussed, and its cousin delete() was added in #286. It feels appropriate to add this now.
This checks the deleted state of the underlying C++ object, which is useful for Python programmers who are about to make calls on a QObject and have some reason to believe it may have been deleted out from under them.