E521 feat(2d): custom arrow heads by ksassnowski · Pull Request #629 · motion-canvas/motion-canvas · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ksassnowski
Copy link
Contributor

This is a continuation of #389.

Closes #380

@strau0106 I have added you as a co-author to this PR since you did most of the work on this.

Co-Authored-By: strau0106 <60017680+strau0106@users.noreply.github.com>
@strau0106
Copy link

great thanks!

@strau0106
Copy link

What's up with this?

@ksassnowski
Copy link
Contributor Author

We decided to change how the arrow head node gets positioned. Previously, it would put the node's center (its position) at the tip of the arrow. Now the arrow head gets positioned based on it's offset. This leads to a few degenerate cases when having to shrink the arrow head when the line's length decreases. I haven't had the time to figure out a solution to this, unfortunately.

@strau0106
Copy link
strau0106 commented Jul 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customizable shape for the Line Arrowheads

2 participants

0