Add option to create a sample file with a custom filename and fix the run command when running with a custom event file#51
Merged
DeviaVir merged 1 commit intomotdotla:masterfrom Apr 18, 2016
Conversation
… run command when running with a custom event file
|
|
||
| Lambda.prototype.run = function (program) { | ||
| this._createSampleFile('event.json'); | ||
| this._createSampleFile('event.json', program.eventFile); |
Collaborator
There was a problem hiding this comment.
I think it would be cleaner if we would just replace this by:
this._createSampleFile(program.eventFile); and disregard https://github.com/motdotla/node-lambda/pull/51/files#diff-16b7d75b70953cbf4755508170f2f24cR21 since the default would be event.json and if you overwrite it we should use that instead.
Thoughts @pedrocarrico ?
Collaborator
There was a problem hiding this comment.
DIsregard my comments, we do want to use the correct boilerplate.
Contributor
Author
There was a problem hiding this comment.
Sorry, didn't have much time to review your comments lately.
Thank you for merging 👍
Collaborator
There was a problem hiding this comment.
Np, thanks for your contribution @pedrocarrico! 💃
DeviaVir
added a commit
that referenced
this pull request
Apr 18, 2016
* Added package command to create a local zip. Exclude *.env files from being uploaded to amazon. Exclude .git* to exclude .gitignore. Exclude test from zip. Exclude packageDirectory from zip if specified. * added test for refactored _archive method. * Add -e to not escape \n when echo'ing * VpcConfig support: - http://docs.aws.amazon.com/lambda/latest/dg/API_VpcConfig.html - http://docs.aws.amazon.com/lambda/latest/dg/vpc.html This allows users to place their Lambda functions in specific subnets with specific security groups. * Use AWS API 2015-03-31: - Check if the function exists, if it does update else create new - This API provides compatibility with VpcConfig * Only ignore deploy.env by default * Updated readme: MODE is no longer a thing * Throw on failures * - Fix rsync namespaced error - Add editorconfig - Ignore editorconfig * Update to pass callback for nodejs4.3 runtime (#74) * Update to pass callback for nodejs4.3 runtime * Default to recommended runtime * Add note about runtimes * Added note on how to target v0.10.36 * Runhandler: Hotfixes * Runhandler: Hotfixes (#75) * Post install script second atttempt * Post install script * Add '-x' / '--excludeGlobs' args for general file exclusion on deploy. (2) (#80) This lets me e.g. exclude not only `.env` but by `.env.prod` / `.env.dev` and any other junky / sample files that happen to live in the method's directory. Or for that matter to move all those files into a sub- directory and exclude that. Less policy, more flexibility. * Excludes: Ignore *.swp (#81) * Ignore .swp files by default. Remove redundant deploy.env ignore from the examples. * Add option to create a sample file with a custom filename and fix the run command when running with a custom event file (#51) * Feature/context file (#82) * Add context.json example * Add contextFile -x --contextFile parameter * fix contextFile example filename * update setup log message * Runhandler: Hotfixes * Reformat to match existing whitespace * more reformating to match existing whitespace * revert version back to 0.7.1 * Fix indenting * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was running my lambda function with a different event file name (-j option) and I was seeing the event.json file always being created.
I've changed the behaviour of the
_createSampleFilefunction and added an optional argument if we want to supply a different file name and kept the behaviour of the run command of creating a new sample file but now with the file name we supply on the event file option.Tell me what you think.
Thanks,