8000 Add '-x' / '--excludeGlobs' args for general file exclusion on deploy. by rafalyesware · Pull Request #48 · motdotla/node-lambda · GitHub
[go: up one dir, main page]

Skip to content

Add '-x' / '--excludeGlobs' args for general file exclusion on deploy.#48

Closed
rafalyesware wants to merge 5 commits intomotdotla:masterfrom
rafalyesware:rkb-add-exclude-support
8000
Closed

Add '-x' / '--excludeGlobs' args for general file exclusion on deploy.#48
rafalyesware wants to merge 5 commits intomotdotla:masterfrom
rafalyesware:rkb-add-exclude-support

Conversation

@rafalyesware
Copy link

This lets me e.g. exclude not only .env but by .env.prod / .env.dev
and any other junky / sample files that happen to live in the method's
directory. Or for that matter to move all those files into a sub-
directory and exclude that. Less policy, more flexibility.

Fixes #44 and fixes #32

This lets me e.g. exclude not only `.env` but by `.env.prod` / `.env.dev`
and any other junky / sample files that happen to live in the method's
directory.  Or for that matter to move all those files into a sub-
directory and exclude that.  Less policy, more flexibility.
This excludes some of the files created by `node-lambda setup`,
which while handy for development, aren't at all needed as part
of the data uploaded to AWS Lambda.
@motdotla
Copy link
Owner

Thanks for this @rafalyesware. I'll take a look this weekend.

@rafalyesware
Copy link
Author

Been a few weeks since that weekend; merged up to current master in case it helps @motdotla

@DeviaVir
Copy link
Collaborator
DeviaVir commented Apr 8, 2016

@rafalyesware if we can get https://github.com/rafalyesware/node-lambda/issues/1 merged into your branch, I'd like to get this merged here! Adds great functionality.

@rafalyesware
Copy link
Author

Thanks, I'll see what I can do this weekend.

--rafal
On Apr 8, 2016 5:30 PM, "Chase" notifications@github.com wrote:

@rafalyesware https://github.com/rafalyesware if we can get
rafalyesware#1 https://github.com/rafalyesware/node-lambda/pull/1
merged into your branch, I'd like to get this merged! Adds great
functionality.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#48 (comment)

@DeviaVir
Copy link
Collaborator

As a general point, #40 already wanted to use -x so this might be something we'd have to take a look at to see which makes more sense.

@DeviaVir
Copy link
Collaborator

@rafalyesware did you get a chance to take a look already? I have been keeping the PR up to date with the changes to master.

@DeviaVir
Copy link
Collaborator

Deprecated by: #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make exclude files config external Deployed zip contains temporary files .swp

3 participants

0