8000 Feature upload to s3 and deploy from bucket by abetomo · Pull Request #446 · motdotla/node-lambda · GitHub
[go: up one dir, main page]

Skip to content

Feature upload to s3 and deploy from bucket#446

Merged
DeviaVir merged 8 commits intomotdotla:masterfrom
abetomo:feature_function_update_using_s3
Jul 24, 2018
Merged

Feature upload to s3 and deploy from bucket#446
DeviaVir merged 8 commits intomotdotla:masterfrom
abetomo:feature_function_update_using_s3

Conversation

@abetomo
Copy link
Contributor
@abetomo abetomo commented Jul 24, 2018

fixes #444

Copy link
Collaborator
@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, did you test it out already?

@abetomo
Copy link
Contributor Author
abetomo commented Jul 24, 2018

Thank you for review.
It is already tested when creating a new one.
In the case of update, it is not tested, and it checked and there was a bug and I will fix it.

@abetomo
Copy link
Contributor Author
abetomo commented Jul 24, 2018

Fixed.
In my project, there was no problem as a result of new creation and update test.

@DeviaVir DeviaVir merged commit d09e1d3 into motdotla:master Jul 24, 2018
@abetomo abetomo deleted the feature_function_update_using_s3 branch July 24, 2018 15:37
@teebu
Copy link
teebu commented Jul 24, 2018

works, how long does it take to appear on npmjs?

@abetomo abetomo mentioned this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: upload to s3 and deploy from bucket

3 participants

0