8000 Refactoring lib/schedule_events.js by abetomo · Pull Request #395 · motdotla/node-lambda · GitHub
[go: up one dir, main page]
Skip to content

Refactoring lib/schedule_events.js#395

Merged
DeviaVir merged 2 commits intomotdotla:masterfrom
abetomo:clean_schedule_events.js_promise_chain
Dec 11, 2017
Merged

Refactoring lib/schedule_events.js#395
DeviaVir merged 2 commits intomotdotla:masterfrom
abetomo:clean_schedule_events.js_promise_chain

Conversation

@abetomo
Copy link
Contributor
@abetomo abetomo commented Dec 9, 2017
  • Use reject
  • () Omitted

DeviaVir
DeviaVir approved these changes Dec 11, 2017
View reviewed changes
Copy link
Collaborator
@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 promisifying

@DeviaVir DeviaVir merged commit c764b61 into motdotla:master Dec 11, 2017
@DeviaVir DeviaVir mentioned this pull request Dec 11, 2017
Merged
@abetomo abetomo deleted the clean_schedule_events.js_promise_chain branch December 12, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo @DeviaVir
0