8000 :sparkles: moban file inheritance by chfw · Pull Request #346 · moremoban/moban · GitHub
[go: up one dir, main page]
Skip to content

✨ moban file inheritance #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 9, 2019
Merged

✨ moban file inheritance #346

merged 6 commits into from
Nov 9, 2019

Conversation

chfw
Copy link
Member
@chfw chfw commented Nov 8, 2019 •
edited
Loading

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

@codecov-io
Copy link

Codecov Report

Merging #346 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #346      +/-   ##
==========================================
+ Coverage   96.01%   96.02%   +<.01%     
==========================================
  Files          51       51              
  Lines        2659     2665       +6     
==========================================
+ Hits         2553     2559       +6     
  Misses        106      106
Impacted Files Coverage Δ
moban/main.py 99.23% <ø> (-0.01%) ⬇️
tests/test_docs.py 100% <100%> (ø) ⬆️
moban/core/data_loader.py 95.23% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b19f86...d3e8015. Read the comment docs.

@chfw chfw merged commit 0356213 into dev Nov 9, 2019
@chfw chfw deleted the override-moban-yaml branch November 9, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-io
0