chore: handle other signals #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a unified shutdown handler and extends signal support to gracefully close the server on SIGTERM and SIGQUIT in addition to SIGINT.
- Extracts the shutdown logic into a standalone
shutdownfunction - Registers
shutdownforSIGTERMandSIGQUITsignals - Refactors the existing
SIGINTlistener to use the newshutdownfunction
Comments suppressed due to low confidence (1)
src/index.ts:50
- Add tests that simulate
SIGINT,SIGTERM, andSIGQUITto verify the shutdown handler is called, the server closes gracefully, and the process exits with the correct code.
process.on("SIGINT", shutdown);
himanshusinghs
approved these changes
Jun 24, 2025
fmenezes
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this sug
2DDB
gestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #279