8000 (DOCSP-29210): CRUD > Search Geospatially page by cbullinger · Pull Request #13 · mongodb/docs-kotlin · GitHub
[go: up one dir, main page]
Skip to content

(DOCSP-29210): CRUD > Search Geospatially page #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 18, 2023
Merged

(DOCSP-29210): CRUD > Search Geospatially page #13

merged 7 commits into from
May 18, 2023

Conversation

cbullinger
Copy link
Collaborator
@cbullinger cbullinger commented Apr 21, 2023 •
edited
Loading

Pull Request Info

JIRA - https://jira.mongodb.org/browse/DOCSP-29210
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/docsp-29210-geo/fundamentals/crud/read-operations/geo/

PR Reviewing Guidelines

Pages Updated

CRUD > Read Operations > Search Geospatially page

Changes Made

  • Copy is unchanged from (Java version) of page, except where noted
  • Replace all code examples with generated, tested Kotlin examples

Checklist

  • Are TOCs updated? If landing page, is page added to snooty.toml?
  • Is .rst file renamed to .txt to ensure it's published?
  • Are all API links flagged for TODO (to be updated when API Ref docs are published)?

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@cbullinger cbullinger force-pushed the docsp-29210-geo branch 2 times, most recently from 9ebd815 to aa8aa35 Compare April 21, 2023 13:58
@cbullinger cbullinger marked this pull request as ready for review May 4, 2023 15:45
@cbullinger cbullinger requested a review from mongodben May 4, 2023 15:45
cbullinger
cbullinger commented May 4, 2023
View reviewed changes
mongodben
mongodben reviewed May 5, 2023
View reviewed changes
mongodben
mongodben reviewed May 5, 2023
View reviewed changes
mongodben
mongodben reviewed May 5, 2023
View reviewed changes
mongodben
mongodben requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator
@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice start! few things throughout

@cbullinger cbullinger requested a review from mongodben May 5, 2023 17:30
mongodben
mongodben reviewed May 11, 2023
View reviewed changes
mongodben
mongodben approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator
@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w 1 further suggesiton

@mongodben mongodben requested a review from jyemin May 15, 2023 15:41
@mongodben mongodben added the MVP first publish of docs site label May 16, 2023
jyemin
jyemin approved these changes May 17, 2023
View reviewed changes
@cbullinger cbullinger merged commit a765961 into mongodb:master May 18, 2023
@cbullinger cbullinger deleted the docsp-29210-geo branch May 18, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@mongodben mongodben mongodben approved these changes

Assignees
No one assigned
Labels
MVP first publish of docs site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbullinger @jyemin @mongodben
0