8000 [JAVA] Uncomment reference to Scala API docs after they are released by rachel-mack · Pull Request #528 · mongodb/docs-java · GitHub
[go: up one dir, main page]
Skip to content

[JAVA] Uncomment reference to Scala API docs after they are released #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[JAVA] Uncomment reference to Scala API docs after they are released #528

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6845ce3
uncomment api docs link
rachel-mack Mar 4, 2024
842416e
NR review
rachel-mack Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
uncomment api docs link
  • Loading branch information
@rachel-mack
rachel-mack committed Mar 4, 2024
commit 6845ce3a2c91c785f09c49fd0412f1bafc3c0da3
6 changes: 3 additions & 3 deletions source/upgrade.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ This driver version introduces the following breaking changes:
converts automatically to ``org.mongodb.scala.SingleObservable[Void]``. The
API also exposes ``org.mongodb.scala.Observable[Unit]`` instead of
``org.mongodb.scala.Observable[Void]``.

.. After the 5.0 Scala API docs are released, this line will be uncommented.
For more information, see the `Observable trait documentation <https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
For more information, see the `Observable trait documentation
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Not necessary, but I think it would be helpful to further clarify where this links to

Suggested change
For more information, see the `Observable trait documentation
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
For more information, see the `Observable
<https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__ trait in the Scala API documentation.


- Changes how ``ClusterSettings`` computes
``ClusterConnectionMode``, making it more consistent by using the specified
Expand Down
0