Compare redirect URIs as strings 8000 #989
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw a draft PR that also addresses this: https://github.com/modelcontextprotocol/python-sdk/pull/982/files#diff-0bfdf5a468abdd078a0287db095a4ad5ebfcb04ea3e437026cdc8038c137ecab I'll leave it to a maintainer if they want to close this or merge it in as a bug fix in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When testing the simple auth example server, I encountered 400 status codes from
POST /tokenbecauseTokenHandler.handlewas evaluatingtoken_request.redirect_uri != authorize_request_redirect_uriasTrue.This occurred because
token_request.redirect_uriwas of typeAnyUrl, whileauthorize_request_redirect_uriwasAnyHttpUrl, and comparing these two different Pydantic types always returnsFalse- even if the underlying URLs are the same.(Example:
AnyUrl("http://google.com") == AnyHttpUrl("http://google.com")isFalse.)I believe the example auth server worked before #895 changed some
AnyHttpUrls toAnyUrls in the validation code, but the example server was not updated.How Has This Been Tested?
Tested using Claude Code as the MCP client to connect to the example server:
claude mcp add --transport sse github http://localhost:8000/sseThe auth flow succeeded only after applying this patch.
Breaking Changes
None.
Types of changes
Checklist
Additional context
We could also update the example server to declare the redirect uri as
AnyHttpUrl, but I think comparing the URIs as strings would make the validation less brittle.