8000 fix: catch and rethrow SSEError during SSE connection establishment by zhangch-ss · Pull Request #975 · modelcontextprotocol/python-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix: catch and rethrow SSEError during SSE connection establishment #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: catch and rethrow SSEError during SSE connection establishment #975

wants to merge 1 commit into from
+4 −0

Conversation

zhangch-ss
Copy link

Motivation and Context

Some errors during SSE connection (e.g., SSEError) are fatal and render read/write streams unusable. Instead of sending the exception via read_stream_writer, which may hang, the error is now raised directly so that the caller can handle it appropriately.

How Has This Been Tested?

mcp-config

{
    "mcpServers": {
        "zhipu-web-search-sse": {
            "url": "https://open.bigmodel.cn/api/mcp/web_search/sse?Authorization=xxxxx"
        }
    }
}

Before fix
Error in sse_reader: Expected response header Content-Type to contain 'text/event-stream', got 'application/json'

After fix

    | Traceback (most recent call last):
    |   File "/app/app/core/sse_client.py", line 152, in sse_client
    |     endpoint_url = await tg.start(sse_reader)
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/anyio/_backends/_asyncio.py", line 898, in start
    |     return await future
    |            ^^^^^^^^^^^^
    |   File "/app/app/core/sse_client.py", line 119, in sse_reader
    |     raise sse_exc
    |   File "/app/app/core/sse_client.py", line 71, in sse_reader
    |     async for sse in event_source.aiter_sse():
    |   File "/usr/local/lib/python3.12/site-packages/httpx_sse/_api.py", line 37, in aiter_sse
    |     self._check_content_type()
    |   File "/usr/local/lib/python3.12/site-packages/httpx_sse/_api.py", line 18, in _check_content_type
    |     raise SSEError(
    | httpx_sse._exceptions.SSEError: Expected response header Content-Type to contain 'text/event-stream', got 'application/json'

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhangch-ss
0