chore: create union for working with message content #939
+25
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
approved these changes
Jun 12, 2025
Kludex
reviewed
Jun 12, 2025
| @@ -7,18 +7,16 @@ | |||
| import pydantic_core | |||
| from pydantic import BaseModel, Field, TypeAdapter, validate_call | |||
|
|
|||
| from mcp.types import AudioContent, EmbeddedResource, ImageContent, TextContent | |||
|
|
|||
| CONTENT_TYPES = TextContent | ImageContent | AudioContent | EmbeddedResource | |||
There was a problem hiding this comment.
I will accept this PR as I don't think anyone is importing this directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves message content types into a union and uses that throughout the codebase. Suggested by @Kludex in #725.
Motivation and Context
Simplifies code, makes for fewer places to update when new content types are introduced in the future.
How Has This Been Tested?
Unit tests
Breaking Changes
None
Types of changes
Checklist
Additional context
RootModelas suggested at the top of the file to avoid breaking changes. Using a new type extendingRootModelwould require wrapping all existing usages ofTextContentetc. in that new type.