10000
refactor: align protocol version header capitalization to lowercase #911
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
9ee6458 to
14c3af8
Compare
Standardize the MCP protocol version header name to lowercase "mcp-protocol-version" across the entire codebase for consistency. This change affects: - Client auth module - Client streamable HTTP transport - Server auth routes - Server streamable HTTP transport - Test files The lowercase format aligns with common HTTP header conventions and ensures consistent header handling throughout the SDK.
2ebed85 to
f2524de
Compare
Kludex
approved these changes
Jun 10, 2025
felixweinberger
added a commit
that referenced
this pull request
Jun 11, 2025
felixweinberger
added a commit
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes the MCP protocol version header name to lowercase
mcp-protocol-versionacross the entire Python SDK codebase for consistency.Changes
Changed
MCP-Protocol-Versiontomcp-protocol-versionthroughout and aligned usage of constantsRationale
The lowercase format aligns with common HTTP header conventions (similar to headers like
content-type,accept-encoding, etc.) and ensures consistent header handling throughout the SDK.Test plan